Skip to content

Conversation

@watson
Copy link
Collaborator

@watson watson commented Jan 9, 2026

What does this PR do?

Move all code related to configuration into the config directory (both regular code and test):

  • packages/dd-trace/src/{config_defaults.js => config/defaults.js}
  • packages/dd-trace/src/{ => config}/git_properties.js
  • packages/dd-trace/src/{config-helper.js => config/helper.js}
  • packages/dd-trace/src/{config.js => config/index.js}
  • packages/dd-trace/src/{config_stable.js => config/stable.js}
  • packages/dd-trace/src/{ => config}/supported-configurations.json
  • packages/dd-trace/test/{ => config}/git_properties.spec.js
  • packages/dd-trace/test/{config.spec.js => config/index.spec.js}

Motivation

Improved overview, encapsulation, and code ownership.

@datadog-official

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Overall package size

Self size: 4.41 MB
Deduped: 5.24 MB
No deduping: 5.24 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.14%. Comparing base (772fc3b) to head (54cc87f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7204      +/-   ##
==========================================
+ Coverage   85.12%   85.14%   +0.02%     
==========================================
  Files         529      532       +3     
  Lines       22866    22897      +31     
==========================================
+ Hits        19464    19495      +31     
  Misses       3402     3402              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watson watson force-pushed the watson/refactor-config branch 4 times, most recently from ea80fa8 to c73e589 Compare January 9, 2026 12:35
@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2026

Benchmarks

Benchmark execution time: 2026-01-19 20:24:58

Comparing candidate commit 54cc87f in PR branch watson/refactor-config with baseline commit 772fc3b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 233 metrics, 27 unstable metrics.

Copy link
Member

@simon-id simon-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@watson watson force-pushed the watson/DEBUG-4402/remote-enablement branch from 9317837 to e5614fe Compare January 13, 2026 13:47
@watson watson force-pushed the watson/refactor-config branch 2 times, most recently from fa752ab to 75925f6 Compare January 13, 2026 14:47
@watson watson force-pushed the watson/DEBUG-4402/remote-enablement branch from e5614fe to 862a80c Compare January 13, 2026 14:47
@watson watson changed the base branch from watson/DEBUG-4402/remote-enablement to graphite-base/7204 January 13, 2026 15:15
@watson watson force-pushed the graphite-base/7204 branch from 862a80c to 772fc3b Compare January 19, 2026 19:51
@watson watson force-pushed the watson/refactor-config branch from 75925f6 to 056cef4 Compare January 19, 2026 19:51
@watson watson changed the base branch from graphite-base/7204 to master January 19, 2026 19:51
@watson watson marked this pull request as ready for review January 19, 2026 19:51
@watson watson requested review from a team as code owners January 19, 2026 19:51
@watson watson requested review from a team as code owners January 19, 2026 19:51
@watson watson requested review from BridgeAR and removed request for a team January 19, 2026 19:51
@watson watson enabled auto-merge (squash) January 19, 2026 19:58
@watson watson force-pushed the watson/refactor-config branch from 056cef4 to 54cc87f Compare January 19, 2026 20:14
@watson watson merged commit 971bdd5 into master Jan 19, 2026
897 of 898 checks passed
@watson watson deleted the watson/refactor-config branch January 19, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants