-
Notifications
You must be signed in to change notification settings - Fork 360
fix: do not log a deprecation message using pg #7269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Overall package sizeSelf size: 4.4 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 0dd0883 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7269 +/- ##
==========================================
+ Coverage 80.04% 85.17% +5.13%
==========================================
Files 393 532 +139
Lines 18155 22788 +4633
==========================================
+ Hits 14532 19410 +4878
+ Misses 3623 3378 -245 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-01-19 15:58:46 Comparing candidate commit 0dd0883 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 230 metrics, 30 unstable metrics. |
Just do a brief check what property exists before accessing it. To make sure this does not happen anywhere else, generally throw an error in our tests to verify our instrumentations do not trigger any of deprecation warning. The positive side effect is, that we will know earlier when things are deprecated and can fix them before things actually get changed and we keep customers happier that way due to better overall support. Fixes: #7267
07f537e to
0dd0883
Compare
To make sure this does not happen anywhere else, generally throw an error in our tests to verify our instrumentations do not trigger any of deprecation warning.
The positive side effect is, that we will know earlier when things are deprecated and can fix them before things actually get changed and we keep customers happier that way due to better overall support.
Fixes: #7267