-
Notifications
You must be signed in to change notification settings - Fork 360
fix: improve baggage implementation #7279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This addresses multiple baggage issues and adds further documentation to the new implementation. The regular API is now spec compliant by ignoring non string keys as well as returning the new context consistently when needed. Baggage headers are also improved by not accepting arbitrary strings as keys anymore. They now adhere to the spec as outlined in the code comment. In addition, the parsing now handles optional properties that may be attached.
Overall package sizeSelf size: 4.41 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7279 +/- ##
==========================================
+ Coverage 85.14% 85.37% +0.23%
==========================================
Files 532 316 -216
Lines 22897 12204 -10693
==========================================
- Hits 19495 10419 -9076
+ Misses 3402 1785 -1617 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
BenchmarksBenchmark execution time: 2026-01-20 02:16:09 Comparing candidate commit 398f1e0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 230 metrics, 30 unstable metrics. |
This addresses multiple baggage issues and adds further documentation to the new implementation.
The regular API is now spec compliant by ignoring non string keys as well as returning the new context consistently when needed.
Baggage headers are also improved by not accepting arbitrary strings as keys anymore. They now adhere to the spec as outlined in the code comment.
In addition, the parsing now handles optional properties that may be attached.
TODO:
This is lacking additional tests for the improvements. Especially system tests should be used for the headers.