feat(llmobs): make model name an optional argument for llm(), embedding() #11051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
model_name
argument fromLLMObs.llm(), LLMObs.embedding(), @llmobs.decorators.llm, @llmobs.decorators.embedding
to being an optional argument with a default value ofcustom
.Previously, being a required argument resulted in slight onboarding friction due to breaking if users did not pass in a model name. By being optional and defaulting to a placeholder value, the
llm/embedding()
methods should be easier to use and generate spans.Checklist
Reviewer Checklist