fix(llmobs): llmobs can be re-enabled on fork with agentless enabled [backport 2.21] #12907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…12889) Due to a regression in #11961, agentless writers fail to init in LLMObs on fork, as the `agentless_url` is not passed down in `recreate`, resulting in: ``` File "/app/.venv/lib/python3.11/site-packages/ddtrace/llmobs/_writer.py", line 255, in __init__ raise ValueError("agentless_url is required for agentless mode") ValueError: agentless_url is required for agentless mode ``` The fix is passing the value down appropriately. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 269b3d8)
sabrenner
approved these changes
Mar 26, 2025
BenchmarksBenchmark execution time: 2025-04-02 19:21:56 Comparing candidate commit 577b133 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 417 metrics, 2 unstable metrics. scenario:iast_aspects-ospathjoin_aspect
|
Contributor
Author
|
|
avara1986
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 269b3d8 from #12889 to 2.21.
Due to a regression in #11961, agentless writers fail to init in LLMObs on fork, as the
agentless_urlis not passed down inrecreate, resulting in:The fix is passing the value down appropriately.
Checklist
Reviewer Checklist