-
Notifications
You must be signed in to change notification settings - Fork 441
fix(ci_visibility): use git tag as branch name if no branch name available [backport 3.7] #13495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lable (#13468) When called from a GitHub action triggered on a _tag_ push (not a branch push), we would have no branch name available and make some requests to the backend with a `null` branch, causing a 400 to be returned. This PR changes it so that the tag name is used as the branch name in such circumstances. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 88cbdc8)
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 231 ± 2 ms. The average import time from base is: 232 ± 2 ms. The import time difference between this PR and base is: -1.61 ± 0.09 ms. Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-05-26 14:53:57 Comparing candidate commit 2e5021e in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 481 metrics, 4 unstable metrics. scenario:iast_aspects-replace_aspect
scenario:iast_aspects-rsplit_aspect
scenario:iast_aspects-split_aspect
|
Pull request was closed
Backport 88cbdc8 from #13468 to 3.7.
When called from a GitHub action triggered on a tag push (not a branch push), we would have no branch name available and make some requests to the backend with a
null
branch, causing a 400 to be returned. This PR changes it so that the tag name is used as the branch name in such circumstances.Checklist
Reviewer Checklist
policy
(cherry picked from commit 88cbdc8)