Skip to content

chore: fix trace filter example #13525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

chore: fix trace filter example #13525

merged 2 commits into from
May 29, 2025

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented May 28, 2025

The if statement doesn't work if you copy and paste the example as is. This is a quick fix.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@wantsui wantsui changed the title chore: Fix public doc chore: fix trace filter example May 28, 2025
@wantsui wantsui added the changelog/no-changelog A changelog entry is not required for this PR. label May 28, 2025
@wantsui wantsui marked this pull request as ready for review May 28, 2025 17:50
@wantsui wantsui requested a review from a team as a code owner May 28, 2025 17:50
@wantsui wantsui requested a review from ZStriker19 May 28, 2025 17:50
Copy link
Contributor

CODEOWNERS have been resolved as:

docs/advanced_usage.rst                                                 @DataDog/python-guild

Copy link
Contributor

github-actions bot commented May 28, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 238 ± 3 ms.

The average import time from base is: 241 ± 3 ms.

The import time difference between this PR and base is: -2.8 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.081 ms (0.88%)
ddtrace.bootstrap.sitecustomize 1.401 ms (0.59%)
ddtrace.bootstrap.preload 1.401 ms (0.59%)
ddtrace.internal.remoteconfig.client 0.685 ms (0.29%)
ddtrace 0.680 ms (0.29%)
ddtrace.internal._unpatched 0.026 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented May 28, 2025

Benchmarks

Benchmark execution time: 2025-05-28 19:41:19

Comparing candidate commit be91d57 in PR branch fix-docs with baseline commit 58bd69c in branch main.

Found 2 performance improvements and 5 performance regressions! Performance is the same for 502 metrics, 7 unstable metrics.

scenario:iastaspects-lower_aspect

  • 🟥 execution_time [+206.717ns; +240.371ns] or [+9.043%; +10.516%]

scenario:iastaspects-lstrip_aspect

  • 🟥 execution_time [+1.508µs; +1.593µs] or [+11.595%; +12.245%]

scenario:iastaspects-strip_aspect

  • 🟥 execution_time [+1.064µs; +1.392µs] or [+8.160%; +10.675%]

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+462.851ns; +510.823ns] or [+13.328%; +14.709%]

scenario:iastaspectssplit-splitlines_aspect

  • 🟥 execution_time [+209.386ns; +248.436ns] or [+14.409%; +17.096%]

scenario:iastdjangostartup-appsec

  • 🟩 execution_time [-1.086s; -1.000s] or [-55.385%; -51.013%]

scenario:iastdjangostartup-tracer

  • 🟩 execution_time [-865.945ms; -769.730ms] or [-49.207%; -43.740%]

@emmettbutler emmettbutler enabled auto-merge (squash) May 29, 2025 16:54
@emmettbutler emmettbutler merged commit ea609fd into main May 29, 2025
295 of 296 checks passed
@emmettbutler emmettbutler deleted the fix-docs branch May 29, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants