-
Notifications
You must be signed in to change notification settings - Fork 441
feat(dsm): context support for sqs -> lambda #13526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 235 ± 3 ms. The average import time from base is: 234 ± 3 ms. The import time difference between this PR and base is: 0.3 ± 0.1 ms. The difference is not statistically significant (z = 1.89). Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-05-29 18:02:01 Comparing candidate commit 8869b97 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 485 metrics, 5 unstable metrics. scenario:iastaspects-swapcase_aspect
scenario:iastaspectssplit-rsplit_aspect
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a changelog entry for this?
we probably also want to change this to a feat(dsm):
instead of a chore(dsm):
reno new
slug-name can be something like, "add-sqs-lambda-context-support" (just an example, go with what your heart desires, the name isn't that important)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor thought, and the suggestion for a changelog entry, otherwise lgtm
Co-authored-by: Brett Langdon <[email protected]>
releasenotes/notes/add-sqs-lambda-context-support-5062a60d81055ed7.yaml
Outdated
Show resolved
Hide resolved
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
[email protected] unqueued this merge request |
/remove |
View all feedbacks in Devflow UI.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added the proper support based on AWS message event format for sqs -> lambda.
This allows dsm to properly extract the neccessary context for lambda support
https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html
Checklist
Reviewer Checklist