Skip to content

fix: rm functions_for_code usage in code origins [backport 2.21] #13568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 2, 2025

Backport a6520bc from #13539 to 2.21.

Remove the call to functions_for_code from code origins. For Python3.11+ we'll use the fully qualified name stored on the Code Object:

https://docs.python.org/3/reference/datamodel.html#codeobject.co_qualname

For older version, we'll fall back to the function name.

refs: DEBUG-3967

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Remove the call to `functions_for_code` from code origins. For
Python3.11+ we'll use the fully qualified name stored on the Code
Object:

https://docs.python.org/3/reference/datamodel.html#codeobject.co_qualname

For older version, we'll fall back to the function name.

refs: DEBUG-3967
(cherry picked from commit a6520bc)
@github-actions github-actions bot requested review from a team as code owners June 2, 2025 18:27
@pr-commenter
Copy link

pr-commenter bot commented Jun 2, 2025

Benchmarks

Benchmark execution time: 2025-06-02 19:22:09

Comparing candidate commit 36c5570 in PR branch backport-13539-to-2.21 with baseline commit 64d6eb7 in branch 2.21.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 344 metrics, 2 unstable metrics.

@tylfin tylfin closed this Jun 3, 2025
@tylfin tylfin reopened this Jun 3, 2025
Copy link
Contributor Author

github-actions bot commented Jun 3, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/fix-co-performance-4199f97341fa4aa7.yaml             @DataDog/apm-python
ddtrace/debugging/_origin/span.py                                       @DataDog/debugger-python

@tylfin tylfin enabled auto-merge (squash) June 3, 2025 19:55
@tylfin tylfin merged commit fb2d052 into 2.21 Jun 3, 2025
345 checks passed
@tylfin tylfin deleted the backport-13539-to-2.21 branch June 3, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants