Skip to content

chore(er): ensure max frame per trace (#12791)#13576

Merged
P403n1x87 merged 4 commits into2.21from
backport-12791-to-2.21
Jun 4, 2025
Merged

chore(er): ensure max frame per trace (#12791)#13576
P403n1x87 merged 4 commits into2.21from
backport-12791-to-2.21

Conversation

@tylfin
Copy link
Member

@tylfin tylfin commented Jun 3, 2025

We make sure that the max frame settings is honoured for a whole trace instead of a single span to avoid capturing too many snapshots.

(cherry picked from commit 560b7a6)
(cherry picked from commit bb68a4f)

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We make sure that the max frame settings is honoured for a whole trace
instead of a single span to avoid capturing too many snapshots.

- [ ] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 560b7a6)
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

CODEOWNERS have been resolved as:

ddtrace/debugging/_exception/replay.py                                  @DataDog/debugger-python
ddtrace/settings/exception_replay.py                                    @DataDog/apm-core-python
tests/debugging/exception/test_replay.py                                @DataDog/debugger-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python

@tylfin tylfin requested a review from P403n1x87 June 3, 2025 16:05
@tylfin tylfin marked this pull request as ready for review June 3, 2025 16:05
@tylfin tylfin requested a review from a team as a code owner June 3, 2025 16:05
@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2025

Benchmarks

Benchmark execution time: 2025-06-04 13:36:12

Comparing candidate commit f06ab9e in PR branch backport-12791-to-2.21 with baseline commit fb2d052 in branch 2.21.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 282 metrics, 2 unstable metrics.

We add the setting option to specifiy the maximum number of frames to
capture while collecting exception replay data. By default this is
infinite.

- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
@tylfin tylfin requested review from a team as code owners June 3, 2025 18:05
@tylfin tylfin requested review from avara1986 and juanjux June 3, 2025 18:05
@tylfin tylfin added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 3, 2025
@P403n1x87 P403n1x87 enabled auto-merge (squash) June 4, 2025 10:02
@P403n1x87 P403n1x87 merged commit b294cf2 into 2.21 Jun 4, 2025
292 of 295 checks passed
@P403n1x87 P403n1x87 deleted the backport-12791-to-2.21 branch June 4, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants