Skip to content

ci: prevent git fatal warning in download artifacts job [backport 2.21] #13606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Jun 5, 2025

Backport of #12627 to 2.21

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 5, 2025
@brettlangdon brettlangdon requested review from a team as code owners June 5, 2025 13:57
Copy link
Contributor

github-actions bot commented Jun 5, 2025

CODEOWNERS have been resolved as:

.gitlab/package.yml                                                     @DataDog/python-guild @DataDog/apm-core-python

@brettlangdon brettlangdon enabled auto-merge (squash) June 5, 2025 13:58
@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2025

Benchmarks

Benchmark execution time: 2025-06-05 14:49:20

Comparing candidate commit 197d443 in PR branch backport-12627-to-2.21 with baseline commit 6db5511 in branch 2.21.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 244 metrics, 2 unstable metrics.

@brettlangdon brettlangdon merged commit 4076301 into 2.21 Jun 5, 2025
880 of 881 checks passed
@brettlangdon brettlangdon deleted the backport-12627-to-2.21 branch June 5, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants