fix(llmobs): make sure correct llmobs trace id is returned from export_span [backport 3.9]#13622
Merged
brettlangdon merged 1 commit into3.9from Jun 6, 2025
Merged
fix(llmobs): make sure correct llmobs trace id is returned from export_span [backport 3.9]#13622brettlangdon merged 1 commit into3.9from
export_span [backport 3.9]#13622brettlangdon merged 1 commit into3.9from
Conversation
…rt_span` (#13620) We recently changed how we record our LLMObs trace IDs - from APM trace IDs to new randomly generated ones. However, we missed updating `export_span`. This PR ensures we export the correct trace ID from `export_span`. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit f5bed1c)
Kyle-Verhoog
approved these changes
Jun 6, 2025
brettlangdon
approved these changes
Jun 6, 2025
Contributor
Author
|
|
Contributor
Author
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 282 ± 4 ms. The average import time from base is: 285 ± 4 ms. The import time difference between this PR and base is: -3.1 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-06 21:49:55 Comparing candidate commit 0735889 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 549 metrics, 3 unstable metrics. scenario:iastaspects-format_map_aspect
scenario:iastaspects-upper_aspect
scenario:iastaspectsospath-ospathjoin_aspect
scenario:telemetryaddmetric-flush-1-metric
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport f5bed1c from #13620 to 3.9.
We recently changed how we record our LLMObs trace IDs - from APM trace IDs to new randomly generated ones. However, we missed updating
export_span. This PR ensures we export the correct trace ID fromexport_span.Checklist
Reviewer Checklist