Skip to content

chore(iast): fix header injection attr #13624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Jun 9, 2025

Fix validation introduced in #13546

APPSEC-57163

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jun 9, 2025
Copy link
Contributor

github-actions bot commented Jun 9, 2025

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/_logs.py                                           @DataDog/asm-python
ddtrace/appsec/_iast/taint_sinks/header_injection.py                    @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Jun 9, 2025

Benchmarks

Benchmark execution time: 2025-06-09 08:06:01

Comparing candidate commit f9a090d in PR branch avara1986/fix_header_value with baseline commit 10e09e0 in branch main.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 552 metrics, 7 unstable metrics.

scenario:iastaspects-lower_aspect

  • 🟥 execution_time [+208.354ns; +259.404ns] or [+9.251%; +11.517%]

scenario:iastaspects-replace_aspect

  • 🟥 execution_time [+398.692ns; +528.493ns] or [+8.477%; +11.237%]

scenario:iastaspects-upper_aspect

  • 🟥 execution_time [+237.893ns; +270.746ns] or [+10.614%; +12.080%]

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+363.754ns; +435.539ns] or [+10.467%; +12.533%]

scenario:iastaspectsospath-ospathsplit_aspect

  • 🟥 execution_time [+767.358ns; +895.131ns] or [+15.891%; +18.537%]

Copy link
Contributor

github-actions bot commented Jun 9, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 280 ± 4 ms.

The average import time from base is: 280 ± 4 ms.

The import time difference between this PR and base is: -0.4 ± 0.2 ms.

The difference is not statistically significant (z = -2.34).

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.271 ms (0.45%)
ddtrace 0.670 ms (0.24%)
ddtrace.internal._unpatched 0.022 ms (0.01%)
ddtrace.bootstrap.sitecustomize 0.601 ms (0.21%)
ddtrace.bootstrap.preload 0.601 ms (0.21%)
ddtrace.internal.remoteconfig.client 0.601 ms (0.21%)

@avara1986 avara1986 marked this pull request as ready for review June 9, 2025 14:29
@avara1986 avara1986 requested a review from a team as a code owner June 9, 2025 14:29
@avara1986 avara1986 merged commit 9292dbd into main Jun 11, 2025
521 of 522 checks passed
@avara1986 avara1986 deleted the avara1986/fix_header_value branch June 11, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants