-
Notifications
You must be signed in to change notification settings - Fork 444
fix: wrapping context __exit__ leak #13626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 273 ± 3 ms. The average import time from base is: 275 ± 4 ms. The import time difference between this PR and base is: -2.1 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
releasenotes/notes/fix-wrapping-context-memory-leak-ad3d8f27586ba662.yaml
Show resolved
Hide resolved
BenchmarksBenchmark execution time: 2025-06-09 14:20:47 Comparing candidate commit d99949c in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 549 metrics, 3 unstable metrics. scenario:iastaspects-upper_aspect
scenario:iastaspectsospath-ospathnormcase_aspect
|
We fix a leak in the universal wrapping context caused to bound __exit__ method leaking in CPython 3.9 and 3.10. This was due to a reference to the bound method __exit__ of the universal wrapping context not getting popped from the stack before every return statement. Every call to a wrapped function would then create one such bounded method object that would not get GC'd. No other versions of CPython are affected because the bytecode and/or approach are different.
d99949c
to
060ea5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We fix a leak in the universal wrapping context caused to bound __exit__ method leaking in CPython 3.9 and 3.10. This was due to a reference to the bound method __exit__ of the universal wrapping context not getting popped from the stack before every return statement. Every call to a wrapped function would then create one such bounded method object that would not get GC'd. No other versions of CPython are affected because the bytecode and/or approach are different. ## Checklist - [ ] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit e7c0d74)
We fix a leak in the universal wrapping context caused to bound exit method leaking in CPython 3.9 and 3.10. This was due to a reference to the bound method exit of the universal wrapping context not getting popped from the stack before every return statement. Every call to a wrapped function would then create one such bounded method object that would not get GC'd. No other versions of CPython are affected because the bytecode and/or approach are different.
Checklist
Reviewer Checklist