chore(tracer): add abstract base class for AgentWriterInterface#13876
Merged
brettlangdon merged 8 commits intomainfrom Jul 10, 2025
Merged
chore(tracer): add abstract base class for AgentWriterInterface#13876brettlangdon merged 8 commits intomainfrom
brettlangdon merged 8 commits intomainfrom
Conversation
Preparing the code for a future where we have multiple implementations of the AgentWriter
Contributor
|
|
2 tasks
Contributor
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 284 ± 4 ms. The average import time from base is: 288 ± 5 ms. The import time difference between this PR and base is: -3.6 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-07-10 13:07:26 Comparing candidate commit a328c9b in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 547 metrics, 2 unstable metrics. scenario:iastaspectsospath-ospathjoin_aspect
|
2 tasks
emmettbutler
approved these changes
Jul 7, 2025
Co-authored-by: Emmett Butler <[email protected]>
christophe-papazian
approved these changes
Jul 8, 2025
rachelyangdog
approved these changes
Jul 9, 2025
vitor-de-araujo
approved these changes
Jul 10, 2025
Co-authored-by: Vítor De Araújo <[email protected]>
alyshawang
pushed a commit
that referenced
this pull request
Jul 25, 2025
Preparing the code for a future where we have multiple implementations of the AgentWriter. I grabbed some minor adjacent type hinting stuff as well. Split from #13071 We expect no major changes from this change. The only interesting change is the `agent_url` -> `intake_url` change which this is an internal/private class. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Emmett Butler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing the code for a future where we have multiple implementations of the AgentWriter.
I grabbed some minor adjacent type hinting stuff as well.
Split from #13071
We expect no major changes from this change. The only interesting change is the
agent_url->intake_urlchange which this is an internal/private class.Checklist
Reviewer Checklist