chore(tracer): add abstract base class for AgentWriterInterface #13876
+103
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing the code for a future where we have multiple implementations of the AgentWriter
brettlangdon
added
the
changelog/no-changelog
|
|
2 tasks
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 290 ± 10 ms. The average import time from base is: 278 ± 3 ms. The import time difference between this PR and base is: 14.9 ± 0.5 ms. Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-07-03 20:14:29 Comparing candidate commit b7c2c69 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 478 metrics, 3 unstable metrics. scenario:telemetryaddmetric-1-distribution-metric-1-times
|
VianneyRuhlmann
approved these changes
Jul 4, 2025
Comment on lines
+228
to
+230
| if isinstance(self._span_aggregator.writer, HTTPWriter): | ||
| # For AgentWriterInterface, we can return the intake_url directly | ||
| return self._span_aggregator.writer.intake_url |
There was a problem hiding this comment.
Should we also support AgentWriterInterface instances which are not HTTPWritter ?
Suggested change
| if isinstance(self._span_aggregator.writer, HTTPWriter): | |
| # For AgentWriterInterface, we can return the intake_url directly | |
| return self._span_aggregator.writer.intake_url | |
| if isinstance(self._span_aggregator.writer, HTTPWriter) or isinstance(self._span_aggregator.writer, AgentWriterInterface): | |
| # For AgentWriterInterface, we can return the intake_url directly | |
| return self._span_aggregator.writer.intake_url |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing the code for a future where we have multiple implementations of the AgentWriter.
I grabbed some minor adjacent type hinting stuff as well.
Split from #13071
We expect no major changes from this change. The only interesting change is the
agent_url->intake_urlchange which this is an internal/private class.Checklist
Reviewer Checklist