-
Notifications
You must be signed in to change notification settings - Fork 447
feat(google_genai): apm and llmobs submissions for embed_content google-genai #13880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 289 ± 4 ms. The average import time from base is: 291 ± 4 ms. The import time difference between this PR and base is: -2.0 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-07-09 20:55:02 Comparing candidate commit cfa80de in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 548 metrics, 2 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshot files lgtm, approving for apm-python
a changelog entry should be added for this change. |
releasenotes/notes/google_genai_embed_content_submissions-5824ec6d6ce45895.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Yun Kim <[email protected]>
Co-authored-by: Yun Kim <[email protected]>
…ec6d6ce45895.yaml Co-authored-by: Yun Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits but otherwise LGTM once addressed!
Co-authored-by: Yun Kim <[email protected]>
Co-authored-by: Yun Kim <[email protected]>
MLOB-3048
This PR adds support for APM submissions as well as LLMObs submissions for calls to embed_content (sync and async versions) in Google's GenAI Python SDK.
Checklist
Reviewer Checklist