chore: refactor SpanAggregator <> TraceWriter interface#13894
chore: refactor SpanAggregator <> TraceWriter interface#13894brettlangdon merged 13 commits intomainfrom
Conversation
Help remove some implementation details from SpanAggregator into a the writer module.
|
This is going to have conflicts with #13876 |
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 277 ± 2 ms. The average import time from base is: 278 ± 3 ms. The import time difference between this PR and base is: -1.9 ± 0.1 ms. Import time breakdownThe following import paths have appeared:
|
BenchmarksBenchmark execution time: 2025-07-15 16:51:10 Comparing candidate commit a705cfc in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 547 metrics, 2 unstable metrics. scenario:iastaspectsospath-ospathsplitdrive_aspect
|
VianneyRuhlmann
left a comment
There was a problem hiding this comment.
LGTM, this will also be helpful for the DummyWriter creation with NativeWriter
Co-authored-by: Vítor De Araújo <[email protected]>
Help remove some implementation details from SpanAggregator into a the writer module. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Help remove some implementation details from SpanAggregator into a the writer module.
Checklist
Reviewer Checklist