chore: remove pathlib compatibility code#15315
Conversation
We remove custom compatibility code for pathlib since it was only needed for CPython 3.8.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 219 ± 3 ms. The average import time from base is: 222 ± 3 ms. The import time difference between this PR and base is: -3.4 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate chore/remove-pathlib-compat (c67fd03) with baseline main (f59ebb6) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.6% Memory: ✅ 40.173MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ add_inplace_aspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.7% Memory: ✅ 40.321MB (SLO: <41.500MB -2.8%) vs baseline: +4.2% ✅ add_inplace_noaspectTime: ✅ 0.316µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.8% Memory: ✅ 40.204MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ add_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.4% Memory: ✅ 40.338MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 1.325µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +1.3% Memory: ✅ 40.361MB (SLO: <41.500MB -2.7%) vs baseline: +5.1% ✅ bytearray_extend_aspectTime: ✅ 1.539µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +3.3% Memory: ✅ 40.341MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ bytearray_extend_noaspectTime: ✅ 0.609µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.1% Memory: ✅ 40.321MB (SLO: <41.500MB -2.8%) vs baseline: +4.7% ✅ bytearray_noaspectTime: ✅ 0.477µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -1.5% Memory: ✅ 40.325MB (SLO: <41.500MB -2.8%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 1.304µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +2.1% Memory: ✅ 40.374MB (SLO: <41.500MB -2.7%) vs baseline: +5.2% ✅ bytes_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 40.485MB (SLO: <41.500MB -2.4%) vs baseline: +5.6% ✅ bytesio_aspectTime: ✅ 1.302µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -0.7% Memory: ✅ 40.364MB (SLO: <41.500MB -2.7%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.1% Memory: ✅ 40.422MB (SLO: <41.500MB -2.6%) vs baseline: +5.2% ✅ capitalize_aspectTime: ✅ 0.731µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.3% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.1% Memory: ✅ 40.385MB (SLO: <41.500MB -2.7%) vs baseline: +5.3% ✅ casefold_aspectTime: ✅ 0.739µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.4% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +5.0% ✅ casefold_noaspectTime: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.6% Memory: ✅ 40.264MB (SLO: <41.500MB -3.0%) vs baseline: +4.6% ✅ decode_aspectTime: ✅ 0.721µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.2% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +5.3% ✅ decode_noaspectTime: ✅ 0.419µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -1.3% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.2% ✅ encode_aspectTime: ✅ 0.705µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.7% Memory: ✅ 40.303MB (SLO: <41.500MB -2.9%) vs baseline: +5.1% ✅ encode_noaspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +2.1% Memory: ✅ 40.348MB (SLO: <41.500MB -2.8%) vs baseline: +5.2% ✅ format_aspectTime: ✅ 3.339µs (SLO: <10.000µs 📉 -66.6%) vs baseline: -0.9% Memory: ✅ 40.203MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ format_map_aspectTime: ✅ 3.465µs (SLO: <10.000µs 📉 -65.3%) vs baseline: -3.5% Memory: ✅ 40.240MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ format_map_noaspectTime: ✅ 0.775µs (SLO: <10.000µs 📉 -92.2%) vs baseline: -0.2% Memory: ✅ 40.264MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 0.593µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -1.3% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.360µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +1.2% Memory: ✅ 40.189MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ index_noaspectTime: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: ~same Memory: ✅ 40.346MB (SLO: <41.500MB -2.8%) vs baseline: +5.2% ✅ join_aspectTime: ✅ 1.385µs (SLO: <10.000µs 📉 -86.2%) vs baseline: ~same Memory: ✅ 40.311MB (SLO: <41.500MB -2.9%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.6% Memory: ✅ 40.256MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 2.506µs (SLO: <20.000µs 📉 -87.5%) vs baseline: +0.5% Memory: ✅ 40.199MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.8% Memory: ✅ 40.244MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 2.176µs (SLO: <10.000µs 📉 -78.2%) vs baseline: -1.3% Memory: ✅ 40.340MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ lower_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.5% Memory: ✅ 40.468MB (SLO: <41.500MB -2.5%) vs baseline: +5.2% ✅ lstrip_aspectTime: ✅ 2.236µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +1.5% Memory: ✅ 40.243MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.4% Memory: ✅ 40.346MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ modulo_aspectTime: ✅ 1.043µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +5.8% Memory: ✅ 40.203MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.642µs (SLO: <10.000µs 📉 -83.6%) vs baseline: +6.2% Memory: ✅ 40.275MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ modulo_aspect_for_bytesTime: ✅ 0.974µs (SLO: <10.000µs 📉 -90.3%) vs baseline: -5.4% Memory: ✅ 40.248MB (SLO: <41.500MB -3.0%) vs baseline: +4.4% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.257µs (SLO: <10.000µs 📉 -87.4%) vs baseline: +0.1% Memory: ✅ 40.310MB (SLO: <41.500MB -2.9%) vs baseline: +5.1% ✅ modulo_noaspectTime: ✅ 0.626µs (SLO: <10.000µs 📉 -93.7%) vs baseline: ~same Memory: ✅ 40.428MB (SLO: <41.500MB -2.6%) vs baseline: +5.3% ✅ replace_aspectTime: ✅ 4.871µs (SLO: <10.000µs 📉 -51.3%) vs baseline: +1.3% Memory: ✅ 40.241MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 0.459µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.2% Memory: ✅ 40.363MB (SLO: <41.500MB -2.7%) vs baseline: +4.8% ✅ repr_aspectTime: ✅ 0.914µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.2% Memory: ✅ 40.271MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ repr_noaspectTime: ✅ 0.413µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.0% Memory: ✅ 40.481MB (SLO: <41.500MB -2.5%) vs baseline: +5.2% ✅ rstrip_aspectTime: ✅ 1.890µs (SLO: <20.000µs 📉 -90.6%) vs baseline: -0.2% Memory: ✅ 40.223MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 0.379µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.2% Memory: ✅ 40.326MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ slice_aspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.4% Memory: ✅ 40.252MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.444µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -0.3% Memory: ✅ 40.224MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 1.692µs (SLO: <10.000µs 📉 -83.1%) vs baseline: 📈 +10.8% Memory: ✅ 40.142MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ stringio_noaspectTime: ✅ 0.715µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.1% Memory: ✅ 40.263MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 2.215µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.7% Memory: ✅ 40.258MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.8% Memory: ✅ 40.465MB (SLO: <41.500MB -2.5%) vs baseline: +5.5% ✅ swapcase_aspectTime: ✅ 2.406µs (SLO: <10.000µs 📉 -75.9%) vs baseline: +0.7% Memory: ✅ 40.220MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 0.538µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -0.3% Memory: ✅ 40.463MB (SLO: <41.500MB -2.5%) vs baseline: +5.5% ✅ title_aspectTime: ✅ 2.328µs (SLO: <10.000µs 📉 -76.7%) vs baseline: +0.2% Memory: ✅ 40.341MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ title_noaspectTime: ✅ 0.504µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.2% Memory: ✅ 40.201MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 3.206µs (SLO: <10.000µs 📉 -67.9%) vs baseline: +0.9% Memory: ✅ 40.302MB (SLO: <41.500MB -2.9%) vs baseline: +5.2% ✅ translate_noaspectTime: ✅ 1.045µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.7% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +5.3% ✅ upper_aspectTime: ✅ 2.205µs (SLO: <10.000µs 📉 -78.0%) vs baseline: +0.3% Memory: ✅ 40.321MB (SLO: <41.500MB -2.8%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 0.374µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.2% Memory: ✅ 40.325MB (SLO: <41.500MB -2.8%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.056µs (SLO: <10.000µs 📉 -49.4%) vs baseline: 📈 +17.0% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 1.093µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +1.4% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathjoin_aspectTime: ✅ 6.095µs (SLO: <10.000µs 📉 -39.0%) vs baseline: -1.3% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 2.305µs (SLO: <10.000µs 📉 -76.9%) vs baseline: ~same Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.6% ✅ ospathnormcase_aspectTime: ✅ 3.524µs (SLO: <10.000µs 📉 -64.8%) vs baseline: +0.2% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.3% ✅ ospathnormcase_noaspectTime: ✅ 0.575µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.6% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 4.923µs (SLO: <10.000µs 📉 -50.8%) vs baseline: +1.1% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.596µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.3% Memory: ✅ 40.383MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.701µs (SLO: <10.000µs 📉 -63.0%) vs baseline: ~same Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 0.697µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.5% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.569µs (SLO: <10.000µs 📉 -54.3%) vs baseline: -0.5% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.383µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.4% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.418µs (SLO: <20.000µs 📉 -82.9%) vs baseline: 📈 +17.3% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 201.487µs (SLO: <220.000µs -8.4%) vs baseline: +0.8% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.288µs (SLO: <20.000µs 📉 -83.6%) vs baseline: +1.4% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.498µs (SLO: <230.000µs -6.3%) vs baseline: +0.3% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.185µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.1% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.035µs (SLO: <150.000µs -8.6%) vs baseline: +0.8% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.5% ✅ 1-rate-metric-1-timesTime: ✅ 3.058µs (SLO: <20.000µs 📉 -84.7%) vs baseline: +0.3% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 215.297µs (SLO: <250.000µs 📉 -13.9%) vs baseline: +0.8% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ 100-count-metrics-100-timesTime: ✅ 20.365ms (SLO: <22.000ms -7.4%) vs baseline: +0.7% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.264ms (SLO: <2.300ms 🟡 -1.6%) vs baseline: -0.5% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.412ms (SLO: <1.550ms -8.9%) vs baseline: +0.4% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.213ms (SLO: <2.550ms 📉 -13.2%) vs baseline: -0.4% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.409µs (SLO: <20.000µs 📉 -78.0%) vs baseline: -0.9% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 173.809µs (SLO: <250.000µs 📉 -30.5%) vs baseline: +0.2% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.182ms (SLO: <2.500ms 📉 -12.7%) vs baseline: -0.6% Memory: ✅ 36.038MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +4.9% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
emmettbutler
left a comment
There was a problem hiding this comment.
Thanks for catching this!
Description
We remove custom compatibility code for pathlib since it was only needed for CPython 3.8.