chore(debugger): disable exit spans for Code Origins#15344
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 257 ± 5 ms. The average import time from base is: 258 ± 3 ms. The import time difference between this PR and base is: -0.5 ± 0.2 ms. The difference is not statistically significant (z = -2.58). Import time breakdownThe following import paths have shrunk:
|
c936a19 to
c4a860b
Compare
Performance SLOsComparing candidate tyler.finethy/remove-co-exit-spans (8a4cd07) with baseline main (61c07d1) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.991µs (SLO: <10.000µs 📉 -50.1%) vs baseline: 📈 +20.8% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathbasename_noaspectTime: ✅ 1.080µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.2% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.108µs (SLO: <10.000µs 📉 -38.9%) vs baseline: -0.3% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 2.291µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +1.2% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.433µs (SLO: <10.000µs 📉 -65.7%) vs baseline: +1.1% Memory: ✅ 40.442MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.7% ✅ ospathnormcase_noaspectTime: ✅ 0.565µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.5% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.699µs (SLO: <10.000µs 📉 -53.0%) vs baseline: -0.6% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 1.592µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.7% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 3.654µs (SLO: <10.000µs 📉 -63.5%) vs baseline: +1.2% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.697µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.3% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.518µs (SLO: <10.000µs 📉 -54.8%) vs baseline: +0.3% Memory: ✅ 40.442MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.389µs (SLO: <10.000µs 📉 -86.1%) vs baseline: ~same Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.6% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.450µs (SLO: <20.000µs 📉 -82.8%) vs baseline: 📈 +15.8% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 200.461µs (SLO: <220.000µs -8.9%) vs baseline: -1.4% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.260µs (SLO: <20.000µs 📉 -83.7%) vs baseline: -2.1% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.716µs (SLO: <230.000µs -6.6%) vs baseline: -0.3% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.3% ✅ 1-gauge-metric-1-timesTime: ✅ 2.218µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -0.3% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 138.224µs (SLO: <150.000µs -7.9%) vs baseline: ~same Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.104µs (SLO: <20.000µs 📉 -84.5%) vs baseline: ~same Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 215.709µs (SLO: <250.000µs 📉 -13.7%) vs baseline: -0.3% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ 100-count-metrics-100-timesTime: ✅ 20.601ms (SLO: <22.000ms -6.4%) vs baseline: +1.7% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.258ms (SLO: <2.300ms 🟡 -1.8%) vs baseline: +0.5% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.4% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.427ms (SLO: <1.550ms -7.9%) vs baseline: +1.0% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.225ms (SLO: <2.550ms 📉 -12.7%) vs baseline: +0.2% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.416µs (SLO: <20.000µs 📉 -77.9%) vs baseline: ~same Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 172.985µs (SLO: <250.000µs 📉 -30.8%) vs baseline: -0.5% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.5% ✅ flush-1000-metricsTime: ✅ 2.187ms (SLO: <2.500ms 📉 -12.5%) vs baseline: -0.2% Memory: ✅ 36.058MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +4.8% 🟡 Near SLO Breach (18 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
|
@P403n1x87 this should be good now, tell me if I missed any other references to exit spans |
releasenotes/notes/disable-code-origin-exit-spans-86a0cb0d1619753f.yaml
Outdated
Show resolved
Hide resolved
P403n1x87
left a comment
There was a problem hiding this comment.
LGTM once @brettlangdon's comments are resolved
48a89d6 to
9ace096
Compare
9ace096 to
824e51c
Compare
Exit spans have caused issues in Dotnet/Java, and we made the product decision to remove them from Code Origins for Spans, we'll match that behavior here.
824e51c to
8a4cd07
Compare
Description
Exit spans have caused issues in Dotnet/Java, and we made the product decision to remove them from Code Origins for Spans, we'll match that behavior here.
Testing
Unittests
Risks
Decreases potential for performance regressions.
Additional Notes
N/A