Skip to content

Conversation

@Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Nov 19, 2025

MLOB-4495

Description

Cleans up outdated public docs on already-removed beta prompt-completion sampling feature for our OpenAI/VertexAI/Langchain/Anthropic/Bedrock integrations. We had previously removed them in 3.x but forgot to remove the corresponding integration doc sections.

Also cleans up unused code and integration configs which are remnants of that removed feature (note that these are not breaking changes, tagging APM integration spans with prompt/completion tags was already removed and publicly-documented in release notes in the 3.11 minor release).

Testing

Risks

Additional Notes

@Yun-Kim Yun-Kim requested review from a team as code owners November 19, 2025 19:21
@Yun-Kim Yun-Kim force-pushed the yunkim/llmobs-remove-pc-sampling-docs branch from 8b0d92e to dd99f8b Compare November 19, 2025 19:22
Copy link
Contributor

@sabrenner sabrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one wording nit but can ignore, yeet it

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Yun-Kim Yun-Kim enabled auto-merge (squash) November 19, 2025 19:49
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/contrib/internal/anthropic/__init__.py                          @DataDog/ml-observability
ddtrace/contrib/internal/anthropic/patch.py                             @DataDog/ml-observability
ddtrace/contrib/internal/botocore/__init__.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/botocore/patch.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/langchain/__init__.py                          @DataDog/ml-observability
ddtrace/contrib/internal/openai/__init__.py                             @DataDog/ml-observability
ddtrace/contrib/internal/openai/patch.py                                @DataDog/ml-observability
ddtrace/contrib/internal/vertexai/__init__.py                           @DataDog/ml-observability
ddtrace/contrib/internal/vertexai/patch.py                              @DataDog/ml-observability
ddtrace/llmobs/_integrations/base.py                                    @DataDog/ml-observability
tests/contrib/openai/test_openai_v1.py                                  @DataDog/ml-observability
tests/llmobs/test_llmobs_integrations.py                                @DataDog/ml-observability

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 21, 2025
@github-actions
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 259 ± 3 ms.

The average import time from base is: 261 ± 3 ms.

The import time difference between this PR and base is: -2.2 ± 0.1 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.074 ms (0.03%)
ddtrace.bootstrap.sitecustomize 0.074 ms (0.03%)
ddtrace._trace.trace_handlers 0.048 ms (0.02%)
ddtrace.bootstrap.preload 0.025 ms (0.01%)
ddtrace.internal.settings.crashtracker 0.025 ms (0.01%)

The following import paths have shrunk:

ddtrace.auto 6.134 ms (2.37%)
ddtrace.bootstrap.sitecustomize 3.592 ms (1.39%)
ddtrace.bootstrap.preload 3.592 ms (1.39%)
ddtrace.internal.settings.dynamic_instrumentation 0.661 ms (0.26%)
ddtrace.internal.remoteconfig.worker 0.639 ms (0.25%)
ddtrace.internal.remoteconfig.client 0.529 ms (0.20%)
ddtrace 2.543 ms (0.98%)
ddtrace._logger 0.636 ms (0.25%)
ddtrace.internal.telemetry 0.636 ms (0.25%)
ddtrace.internal.telemetry.writer 0.636 ms (0.25%)
ddtrace.internal.utils.version 0.636 ms (0.25%)
ddtrace.trace 0.578 ms (0.22%)
ddtrace.internal._unpatched 0.026 ms (0.01%)
json 0.026 ms (0.01%)
json.decoder 0.026 ms (0.01%)
re 0.026 ms (0.01%)
enum 0.026 ms (0.01%)
types 0.026 ms (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants