Skip to content

Conversation

@VianneyRuhlmann
Copy link
Contributor

Description

Disable native logging at the end of tests to avoid running all the other tests with logging enabled. Also fixes the same issue in tracer flare tests by fixing the logging cleanup.

Testing

Risks

Additional Notes

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/flare/flare.py                                         @DataDog/apm-core-python
tests/tracer/test_native_logger.py                                      @DataDog/apm-sdk-capabilities-python

@VianneyRuhlmann VianneyRuhlmann added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 20, 2025
@VianneyRuhlmann VianneyRuhlmann marked this pull request as ready for review November 20, 2025 16:58
@VianneyRuhlmann VianneyRuhlmann requested review from a team as code owners November 20, 2025 16:58
@github-actions
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 251 ± 2 ms.

The average import time from base is: 257 ± 3 ms.

The import time difference between this PR and base is: -6.4 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 6.678 ms (2.67%)
ddtrace.bootstrap.sitecustomize 3.940 ms (1.57%)
ddtrace.bootstrap.preload 3.940 ms (1.57%)
ddtrace.internal.settings.dynamic_instrumentation 0.695 ms (0.28%)
ddtrace.internal.remoteconfig.worker 0.665 ms (0.27%)
ddtrace.internal.remoteconfig.client 0.627 ms (0.25%)
ddtrace 2.738 ms (1.09%)
ddtrace.trace 0.709 ms (0.28%)
ddtrace._logger 0.673 ms (0.27%)
ddtrace.internal.telemetry 0.673 ms (0.27%)
ddtrace.internal.telemetry.writer 0.673 ms (0.27%)
ddtrace.internal.utils.version 0.673 ms (0.27%)
ddtrace.internal._unpatched 0.029 ms (0.01%)
json 0.029 ms (0.01%)
json.decoder 0.029 ms (0.01%)
re 0.029 ms (0.01%)
enum 0.029 ms (0.01%)
types 0.029 ms (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants