Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the startupProbe parameter for older Kubernetes clusters that don't support startupProbes #1481

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove the startupProbe parameter for older Kubernetes clusters that don't support startupProbes #1481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5b2421
remove startupProbe for older kubernetes clusters
mrdoggopat Aug 7, 2024
819857f
remove startupProbe for older kubernetes clusters, cleaning up some u…
mrdoggopat Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/datadog/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Datadog changelog

## 3.69.4
* Remove `startupProbe` for older Kubernetes clusters as the support for these started with v1.18

## 3.69.3

* Update `datadog-crds` dependency to `1.7.2`.
Expand Down
2 changes: 1 addition & 1 deletion charts/datadog/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: datadog
version: 3.69.3
version: 3.69.4
appVersion: "7"
description: Datadog Agent
keywords:
Expand Down
2 changes: 1 addition & 1 deletion charts/datadog/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Datadog

![Version: 3.69.3](https://img.shields.io/badge/Version-3.69.3-informational?style=flat-square) ![AppVersion: 7](https://img.shields.io/badge/AppVersion-7-informational?style=flat-square)
![Version: 3.69.4](https://img.shields.io/badge/Version-3.69.4-informational?style=flat-square) ![AppVersion: 7](https://img.shields.io/badge/AppVersion-7-informational?style=flat-square)

[Datadog](https://www.datadoghq.com/) is a hosted infrastructure monitoring platform. This chart adds the Datadog Agent to all nodes in your cluster via a DaemonSet. It also optionally depends on the [kube-state-metrics chart](https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-state-metrics). For more information about monitoring Kubernetes with Datadog, please refer to the [Datadog documentation website](https://docs.datadoghq.com/agent/basic_agent_usage/kubernetes/).

Expand Down
2 changes: 2 additions & 0 deletions charts/datadog/templates/_container-agent.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,9 @@
{{- $ready := .Values.agents.containers.agent.readinessProbe }}
{{ include "probe.http" (dict "path" "/ready" "port" $healthPort "settings" $ready) | indent 4 }}
{{- if (not .Values.providers.gke.autopilot) }}
{{- if semverCompare ">= 1.18-0" .Capabilities.KubeVersion.GitVersion }}
startupProbe:
{{- end }}
{{- $startup := .Values.agents.containers.agent.startupProbe }}
{{ include "probe.http" (dict "path" "/startup" "port" $healthPort "settings" $startup) | indent 4 }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions charts/datadog/templates/agent-clusterchecks-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,9 @@ spec:
readinessProbe:
{{- $ready := .Values.clusterChecksRunner.readinessProbe }}
{{ include "probe.http" (dict "settings" $ready "path" "/ready" "port" $healthPort) | indent 10 }}
{{- if semverCompare ">= 1.18-0" .Capabilities.KubeVersion.GitVersion }}
startupProbe:
{{- end }}
{{- $startup := .Values.clusterChecksRunner.startupProbe }}
{{ include "probe.http" (dict "settings" $startup "path" "/startup" "port" $healthPort) | indent 10 }}
volumes:
Expand Down
2 changes: 2 additions & 0 deletions charts/datadog/templates/cluster-agent-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,9 @@ spec:
readinessProbe:
{{- $ready := .Values.clusterAgent.readinessProbe }}
{{ include "probe.http" (dict "path" "/ready" "port" $healthPort "settings" $ready) | indent 10 }}
{{- if semverCompare ">= 1.18-0" .Capabilities.KubeVersion.GitVersion }}
startupProbe:
{{- end }}
{{- $startup := .Values.clusterAgent.startupProbe }}
{{ include "probe.http" (dict "path" "/startup" "port" $healthPort "settings" $startup) | indent 10 }}
{{- if .Values.clusterAgent.containers.clusterAgent.securityContext }}
Expand Down
Loading