Open
Conversation
The include function call is split across two lines, which Go templates do NOT allow and is treated as an unclosed action, hence the “unclosed action” meltdown from Helm. This was causing issue in datadog helm deployment with error Error: UPGRADE FAILED: parse error at (datadog/templates/_helpers.tpl:540): unclosed action helm.go:81: [debug] parse error at (datadog/templates/_helpers.tpl:540): unclosed action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The include function call is split across two lines, which Go templates do NOT allow and is treated as an unclosed action, hence the “unclosed action” meltdown from Helm. This was causing issue in datadog helm deployment with error
Error: UPGRADE FAILED: parse error at (datadog/templates/_helpers.tpl:540): unclosed action helm.go:81: [debug] parse error at (datadog/templates/_helpers.tpl:540): unclosed action
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)GitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md