add(datadog-csi-driver): add podLabels settings to the CSI driver.#2193
Open
hongyiweiwu01 wants to merge 1 commit intoDataDog:mainfrom
Open
add(datadog-csi-driver): add podLabels settings to the CSI driver.#2193hongyiweiwu01 wants to merge 1 commit intoDataDog:mainfrom
hongyiweiwu01 wants to merge 1 commit intoDataDog:mainfrom
Conversation
Contributor
|
Hello @hongyiweiwu01 Thank you for making this contribution and apologies for the delay in the review. I see the charts have evolved and resulted in many conflicts, could you clean this up so I can proceed with the review ? 🙇 Otherwise, we can implement this on our side. thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new
podLabelsvalue to the CSI driver chart, which allows customizing the labels added to the pods spawned by the CSI chart. It additionally allows specifying this value in the main Datadog chart, which will pass this value through to the CSI sub chart.Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)GitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md