Build Cryptography wheel for Windows #18981
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alopezz
force-pushed
the
alopez/build-cryptography-fips
branch
2 times, most recently
from
283dfdd to
19ad598
Compare
alopezz
force-pushed
the
alopez/build-cryptography-fips
branch
6 times, most recently
from
b6c9e79 to
4e6ef06
Compare
dkirov-dd
reviewed
Feb 17, 2025
alopezz
force-pushed
the
alopez/build-cryptography-fips
branch
10 times, most recently
from
79c27fc to
e528dcd
Compare
alopezz
force-pushed
the
alopez/build-cryptography-fips
branch
2 times, most recently
from
8c9286a to
694016b
Compare
datadog-agent-integrations-bot
bot
added
team/agent-integrations
team/agent-delivery
FlorentClarret
previously approved these changes
Feb 26, 2025
temporal-github-worker-1
bot
dismissed
FlorentClarret’s stale review
Review from FlorentClarret is dismissed.
Related teams and files:
- agent-delivery
- .builders/images/windows-x86_64/Dockerfile
FlorentClarret
previously approved these changes
Feb 26, 2025
dkirov-dd
previously approved these changes
Feb 26, 2025
alopezz
force-pushed
the
alopez/build-cryptography-fips
branch
from
77d56db to
d0993c5
Compare
temporal-github-worker-1
bot
dismissed stale reviews from FlorentClarret and dkirov-dd
Review from FlorentClarret is dismissed.
Related teams and files:
- agent-delivery
- .builders/images/helpers.ps1
- .builders/images/windows-x86_64/Dockerfile
- .builders/images/windows-x86_64/build_script.ps1
Review from dkirov-dd is dismissed.
Related teams and files:
- agent-integrations
- .builders/images/helpers.ps1
- .builders/images/windows-x86_64/Dockerfile
- .builders/images/windows-x86_64/build_script.ps1
temporal-github-worker-1
bot
added
agent/review-requested
and removed
agent/approved
labels
dkirov-dd
approved these changes
Mar 4, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
|
I'm closing this for now, as there are problems with the approach that involves this build and therefore for now this is not desirable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Forces the build of cryptography for Windows, so that we get our own wheels with dynamic linking to openssl.
I've done some testing on a Windows VM and this would seem to help us solve the current issue in a similar way that we do for Linux.
Motivation
FIPS support.
BARX-668
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged