Skip to content

Stop using the uptime library #19842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Stop using the uptime library #19842

merged 1 commit into from
Mar 17, 2025

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Mar 14, 2025

What does this PR do?

Stop using the uptime library.

Motivation

  • uptime is no longer maintained (last release: 2013)
  • We already have psutil, which is maintained, and can be used to achieve the same thing
  • We use it in only one check and for its legacy version it seems
  • It's not used in extras, marketplace nor internal
  • Even if uptime is lightweight, that's still one less deps to ship with the agent

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.78%. Comparing base (78dea73) to head (1d73efd).
Report is 8 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
datadog_checks_base 89.48% <ø> (+0.39%) ⬆️
datadog_checks_dev 77.58% <ø> (ø)
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
win32_event_log 86.54% <60.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FlorentClarret FlorentClarret force-pushed the florentclarret/uptime branch 2 times, most recently from 320e4db to c6f8126 Compare March 14, 2025 16:01
@FlorentClarret FlorentClarret force-pushed the florentclarret/uptime branch 3 times, most recently from 6f8109b to 17f9947 Compare March 14, 2025 16:09
@FlorentClarret FlorentClarret added this pull request to the merge queue Mar 17, 2025
Merged via the queue into master with commit ea404ef Mar 17, 2025
60 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/uptime branch March 17, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants