Skip to content

[AI-5184] pin urllib3 #19900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025
Merged

[AI-5184] pin urllib3 #19900

merged 3 commits into from
Apr 4, 2025

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Mar 20, 2025

What does this PR do?

pins urllib3, a transitive dep of requests that we sometimes use

Motivation

we use it here:

if __getattr__('datadog_agent').get_config('use_boringssl'):

and here https://github.com/DataDog/integrations-core/blob/master/datadog_checks_base/datadog_checks/base/log.py#L166-L170

and https://github.com/DataDog/integrations-core/blob/master/datadog_checks_base/datadog_checks/base/utils/http.py#L20

if they reorganize their imports/package structure that could potentially break things for us

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (7380f75) to head (a16ccef).
Report is 66 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
datadog_checks_base 89.40% <ø> (+0.37%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarah-witt sarah-witt changed the title pin urllib3 [AI-5184] pin urllib3 Mar 20, 2025
@sarah-witt sarah-witt marked this pull request as ready for review March 20, 2025 19:38
@sarah-witt sarah-witt requested a review from a team as a code owner March 20, 2025 19:38
@sarah-witt sarah-witt added this pull request to the merge queue Apr 4, 2025
Merged via the queue into master with commit ad36d85 Apr 4, 2025
51 checks passed
@sarah-witt sarah-witt deleted the sarah/pin-urrlib3 branch April 4, 2025 13:13
github-actions bot pushed a commit that referenced this pull request Apr 4, 2025
* pin urllib3

* Add comment to pyproject.toml

* spacing: ad36d85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants