-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AI-5281] Barracuda Secure Edge Integration PR #20423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[AI-5281] Barracuda Secure Edge Integration PR #20423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because this PR is just a skeleton and "display_on_public_website": false
is set in the manifest.json, I'm approving this on behalf of documentation
Review from cswatt is dismissed. Related teams and files:
- documentation
- barracuda_secure_edge/manifest.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than CI failures this looks ok to me, so approving as a first step.
hey @cswatt looks like the description needs updating (@vinodkumar-sacumen will update), please have a look at the PR from a docs perspective. It does have Assets that we can use docs review/approval on. |
ab6d522
to
b00a197
Compare
Review from iliakur is dismissed. Related teams and files:
- agent-integrations
- .github/CODEOWNERS
- .github/workflows/config/labeler.yml
- barracuda_secure_edge/CHANGELOG.md
- barracuda_secure_edge/README.md
- barracuda_secure_edge/assets/configuration/spec.yaml
- barracuda_secure_edge/assets/dashboards/barracuda_secure_edge_overview.json
- barracuda_secure_edge/changelog.d/20423.added
- barracuda_secure_edge/datadog_checks/barracuda_secure_edge/about.py
- barracuda_secure_edge/datadog_checks/barracuda_secure_edge/init.py
- barracuda_secure_edge/datadog_checks/barracuda_secure_edge/data/conf.yaml.example
- barracuda_secure_edge/images/secureEdge1.png
- barracuda_secure_edge/images/secureEdge2.png
- barracuda_secure_edge/images/secure_edge_overview.png
- barracuda_secure_edge/manifest.json
- barracuda_secure_edge/pyproject.toml
92e4d60
to
48c4f43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this one is missing some steps
@@ -0,0 +1,2498 @@ | |||
{ | |||
"title": "Barracuda Secure Edge", | |||
"description": "[[suggested_dashboards]]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is placeholder text
{ | ||
"id": 5966799396123124, | ||
"definition": { | ||
"title": "Network Event Timeline", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this title, checking if the double space was intentional
{ | ||
"id": 6000789218138106, | ||
"definition": { | ||
"title": "Auth Access Event Timeline", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before, noticed double spaces
{ | ||
"id": 3172417779844822, | ||
"definition": { | ||
"title": "Auth Access Event level", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"L" to be capitalized as part of title
"configuration": "README.md#Setup", | ||
"support": "README.md#Support", | ||
"changelog": "CHANGELOG.md", | ||
"description": "SecureEdge is a unified SASE platform that includes NGFW, zero trust and secure SD-WAN", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this description section is searchable. As such it should include "Barracuda". I also recommend writing out the acronyms and having the acronym itself follow in parentheses i.e. Secure Access Service Edge (SASE).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have restricted it due to line length CI check issue.
48c4f43
to
00284d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few initial suggestions and feedback from Docs. Thanks!
b565132
to
348069e
Compare
|
||
1. Administrative access to Barracuda Secure Edge installed on your server. | ||
2. The Datadog Agent installed and running (on a server or container that can receive syslog messages). | ||
3. Network Access between the firewall and the Datadog Agent (usually port 514, but may be a custom value). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3. Network Access between the firewall and the Datadog Agent (usually port 514, but may be a custom value). | |
3. Network access between the firewall and the Datadog Agent (usually port 514, but may be a custom value). |
1. Administrative access to Barracuda Secure Edge installed on your server. | ||
2. The Datadog Agent installed and running (on a server or container that can receive syslog messages). | ||
3. Network Access between the firewall and the Datadog Agent (usually port 514, but may be a custom value). | ||
4. Syslog support enabled in the Datadog Agent (with a TCP or UDP listener configured). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Administrative access to Barracuda Secure Edge installed on your server. | |
2. The Datadog Agent installed and running (on a server or container that can receive syslog messages). | |
3. Network Access between the firewall and the Datadog Agent (usually port 514, but may be a custom value). | |
4. Syslog support enabled in the Datadog Agent (with a TCP or UDP listener configured). | |
- Administrative access to Barracuda Secure Edge installed on your server. | |
- The Datadog Agent installed and running (on a server or container that can receive syslog messages). | |
- Network Access between the firewall and the Datadog Agent (usually port 514, but may be a custom value). | |
- Syslog support enabled in the Datadog Agent (with a TCP or UDP listener configured). |
3. Network Access between the firewall and the Datadog Agent (usually port 514, but may be a custom value). | ||
4. Syslog support enabled in the Datadog Agent (with a TCP or UDP listener configured). | ||
|
||
### Setup Configurations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Setup Configurations | |
### Setup configuration |
### Metrics | ||
|
||
Barracuda_Secure_Edge does not include any metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Metrics | |
Barracuda_Secure_Edge does not include any metrics. |
Duplicated below.
What does this PR do?
This is a initial release PR of Barracuda SecureEdge Firewall integration including all the required assets.
Motivation
This is beta release of Agent based integration and is intended for internal testing before going live. We will raise a separate PR with assets and all necessary information once this PR has been merged.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged