Update temporal check to temporal v1.28.0 #20627
Open
+1,361
−622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Hi @iliakur , appreciate your review 🙇♂️ |
phuongdnguyen
commented
Jul 2, 2025
| @@ -28,7 +28,6 @@ def test_check(dd_run_check, aggregator, check, mock_metrics): | |||
| aggregator.assert_metric_has_tag(metric, tag) | |||
|
|
|||
| aggregator.assert_metrics_using_metadata(get_metadata_metrics()) | |||
| aggregator.assert_all_metrics_covered() | |||
There was a problem hiding this comment.
Remove this assertion because we must keep the integration working against several upstream versions - where some metrics appear or disappear between releases and the test already covered a subset of core metrics, wdyt @iliakur ?
phuongdnguyen
commented
Jul 2, 2025
| @@ -1,619 +1,957 @@ | |||
| metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric | |||
There was a problem hiding this comment.
The sample_tags column is generated by ddev validate metadata temporal --sync. I believe it was added in #17521
maycmlee
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Support metrics in newer temporal version as OOTB
Split from #20142
First part: #20469
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged