Skip to content

Remove time_elasped metrics from Falco #20634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Jul 1, 2025

What does this PR do?

This PR removes 2 metrics with type time_elapsed since our base class can't properly convert them from nanoseconds to a useable metric.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (8916382) to head (c4432ee).
Report is 9 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
falco 95.65% <ø> (ø)
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sarah-witt
sarah-witt previously approved these changes Jul 1, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed sarah-witt’s stale review July 1, 2025 21:58

Review from sarah-witt is dismissed. Related teams and files:

  • agent-integrations
    • falco/changelog.d/20634.removed
Copy link

github-actions bot commented Jul 1, 2025

⚠️ Major version bump
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

sarah-witt
sarah-witt previously approved these changes Jul 1, 2025
steveny91
steveny91 previously approved these changes Jul 1, 2025
@Kyle-Neale Kyle-Neale force-pushed the kyle.neale/remove-falco-time_elapsed-metrics branch from 4e40f44 to c4432ee Compare July 2, 2025 14:17
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed stale reviews from sarah-witt and steveny91 July 2, 2025 14:17

Review from sarah-witt is dismissed. Related teams and files:

  • agent-integrations
    • falco/changelog.d/20634.removed

Review from steveny91 is dismissed. Related teams and files:

  • agent-integrations
    • falco/changelog.d/20634.removed
@Kyle-Neale Kyle-Neale added this pull request to the merge queue Jul 2, 2025
Merged via the queue into master with commit abdf3a1 Jul 2, 2025
42 checks passed
@Kyle-Neale Kyle-Neale deleted the kyle.neale/remove-falco-time_elapsed-metrics branch July 2, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants