[SDBM-2278] Memory optimizations for high-instance PostgreSQL monitoring #22354
+98
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address memory issues affecting customers with 200+ PostgreSQL instances. Based on profiler data showing top memory consumers. Changes: - Add LRU cache to degeneralise_tag (was #1 consumer at ~890 MiB) - Strip query text from _previous_statements cache (~376 MiB savings) - Set num_workers=1 in ConnectionPool to reduce thread overhead Test results (60 instances, 1GB limit, 33 min): - Memory: 964 MiB → 726 MiB (-25%) - Threads: 220 → 164 (-25%) - Stable memory vs creeping baseline Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add tests to verify the LRU caching behavior of degeneralise_tag: - Caching returns consistent results for same inputs - Cache key includes check name to prevent collisions - Tags without values are handled correctly - Cache statistics are available and functioning Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Address memory issues affecting customers monitoring multiple PostgreSQL instances.
Changes implemented based on profiler data showing top memory consumers.
Changes:
Motivation
Customer-reported Memory increase issue
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged