-
Notifications
You must be signed in to change notification settings - Fork 799
CloudAEye Integration with Datadog (ECOINT-19) #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Created Jira card for Docs Team editorial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include an out-of-the-box dashboard with your integration, and images of the dashboard
👋 Quick heads up that I will be out of office next week so there may be a delay in the review from my end until July 8th. With that said, other teams will continue to review the PR. Thanks in advance for your patience! |
Hi @bhavyalatha26 - Thank you for making the changes! Your PR is missing the codeowners file. Could you please add the codeowners file to the PR? To edit via web ui:
|
Hi @emarsha94, Thanks for the details. Had a look at the codeowners file, can you please confirm if this is how I need to add an entry in the Community Partners section:
Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final changes then we can approve! Thank you for all of your hard work. In addition to the changes, please ensure you are resolving the validation errors here.
Co-authored-by: emarsha94 <[email protected]>
@JoshPatel13 I made the recommended changes, but 1 test is still failing due to some ddev issue. Can you please check and let us know the fix |
Hi, to fix the service_checks issue, you need a |
Hi @JoshPatel13 what should be the content of that file ? |
It can just have |
Made the changes suggested, still two more tests are failing. Regards, |
Can you try adding the file to the
inside the Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes
Done |
Co-authored-by: emarsha94 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This PR is to add CloudAEye Integration plugin in Datadog. This is for the tile-only-listing API-based integration.
Motivation
We want to integrate our services with datadog.
Review checklist
no-changelog
label attached