Skip to content

CloudAEye Integration with Datadog (ECOINT-19) #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Nov 13, 2024

Conversation

ankit-cloudaeye
Copy link
Contributor

What does this PR do?

This PR is to add CloudAEye Integration plugin in Datadog. This is for the tile-only-listing API-based integration.

Motivation

We want to integrate our services with datadog.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

@ankit-cloudaeye ankit-cloudaeye requested review from a team as code owners May 21, 2024 22:07
@drichards-87
Copy link
Contributor

Created Jira card for Docs Team editorial review.

Copy link
Collaborator

@emarsha94 emarsha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include an out-of-the-box dashboard with your integration, and images of the dashboard

@ankit-cloudaeye ankit-cloudaeye requested a review from a team as a code owner June 13, 2024 21:16
@emarsha94
Copy link
Collaborator

👋 Quick heads up that I will be out of office next week so there may be a delay in the review from my end until July 8th. With that said, other teams will continue to review the PR. Thanks in advance for your patience!

@emarsha94
Copy link
Collaborator

Hi @bhavyalatha26 - Thank you for making the changes! Your PR is missing the codeowners file. Could you please add the codeowners file to the PR? To edit via web ui:

  1. Go to your forked repository > .github > CODEOWNERS file
  2. Edit the file by clicking the pencil icon in the top right
  3. Add your integration name and github handle in alphabetical order
  4. Click Commit changes directly to the master branch

@bhavyalatha26
Copy link
Contributor

Hi @bhavyalatha26 - Thank you for making the changes! Your PR is missing the codeowners file. Could you please add the codeowners file to the PR? To edit via web ui:

1. Go to your forked repository > .github > CODEOWNERS file

2. Edit the file by clicking the pencil icon in the top right

3. Add your integration name and github handle in alphabetical order

4. Click Commit changes directly to the master branch

Hi @emarsha94,

Thanks for the details. Had a look at the codeowners file, can you please confirm if this is how I need to add an entry in the Community Partners section:

/cloudaeye_integration/                  @CloudAEye [email protected] @DataDog/integration-extras

Regards,
Bhavya

Copy link
Collaborator

@emarsha94 emarsha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final changes then we can approve! Thank you for all of your hard work. In addition to the changes, please ensure you are resolving the validation errors here.

@emarsha94 emarsha94 requested a review from JoshPatel13 October 16, 2024 20:25
@bhavyalatha26
Copy link
Contributor

@JoshPatel13 I made the recommended changes, but 1 test is still failing due to some ddev issue. Can you please check and let us know the fix

@JoshPatel13
Copy link
Contributor

Hi, to fix the service_checks issue, you need a service_checks.json in the cloudaeye directory.

@bhavyalatha26
Copy link
Contributor

Hi, to fix the service_checks issue, you need a service_checks.json in the cloudaeye directory.

Hi @JoshPatel13 what should be the content of that file ?

@JoshPatel13
Copy link
Contributor

It can just have []

@bhavyalatha26
Copy link
Contributor

It can just have []

Made the changes suggested, still two more tests are failing.

Regards,
Bhavya

@JoshPatel13
Copy link
Contributor

Can you try adding the file to the assets folder instead of it being outside of it. Also in the manifest, can you add

"service_checks": {
        "metadata_path": "assets/service_checks.json"
      },

inside the integration object

Thanks :)

Copy link
Contributor

@JoshPatel13 JoshPatel13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes

@bhavyalatha26
Copy link
Contributor

Requesting changes

Done

Copy link
Contributor

@JoshPatel13 JoshPatel13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoshPatel13 JoshPatel13 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into DataDog:master with commit d1a8c65 Nov 13, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants