[ecos 1459] Move all marketplace further reading readme sections to the manifest #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bgoldberg122 merged 3 commits into master from bgoldberg122/ecos-1459_move-further-reading-section-to-manifests

Jun 18, 2024

Contributor

bgoldberg122 commented Jun 3, 2024 •

edited

Loading

What does this PR do?

Migrates README further reading sections to new manifest field

Motivation

A new tile.resources field was added to the manifest to display rich link previews for further reading resources in the app listings

Review checklist

PR has a meaningful title or PR has the no-changelog label attached
Feature or bugfix has tests
Git history is clean
If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

github-actions bot commented Jun 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

bgoldberg122 changed the title ~~Move all marketplace further reading readme sections to the manifest~~ [ecos 1459] Move all marketplace further reading readme sections to the manifest

github-actions bot commented Jun 4, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

bgoldberg122 commented

View reviewed changes

apptrail/manifest.json Outdated Show resolved Hide resolved

github-actions bot commented Jun 10, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

bgoldberg122 marked this pull request as ready for review

June 17, 2024 17:19

bgoldberg122 requested review from a team as code owners

June 17, 2024 17:19

bgoldberg122 requested a review from mgarabed

June 17, 2024 17:19

github-actions bot commented Jun 17, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

bgoldberg122 added 2 commits

June 17, 2024 13:29


          Move all marketplace further reading readme sections to the manifest

544864d


          Remove apptrail resources

adf2438

Apptrail is no longer an app and these links are broken

bgoldberg122 force-pushed the bgoldberg122/ecos-1459_move-further-reading-section-to-manifests branch from 2715e2e to adf2438 Compare

June 17, 2024 17:29

github-actions bot commented Jun 17, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.


          re-run script

fd991b3

github-actions bot commented Jun 17, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

nmuesch approved these changes

View reviewed changes

Contributor

urseberry commented Jun 17, 2024

The Documentation team will address this after DASH, since it requires us to make a code change.

urseberry added the editorial review label

Contributor

urseberry commented Jun 17, 2024

The Documentation team will address this after DASH, since it requires us to make a code change.

Never mind, I can review now, Ben came up with a workaround.

urseberry removed the editorial review label

urseberry approved these changes

View reviewed changes

xgouchet approved these changes

View reviewed changes

bgoldberg122 merged commit 98e4a18 into master

24 of 25 checks passed

bgoldberg122 deleted the bgoldberg122/ecos-1459_move-further-reading-section-to-manifests branch

June 18, 2024 13:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet