Skip to content

Redis enterprise - added dash to name of overview dashboard #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 93 commits into from
Jul 1, 2024

Conversation

j8-redis
Copy link
Collaborator

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

This reverts commit 105a35d.
@emarsha94 emarsha94 requested a review from bgoldberg122 June 18, 2024 13:38
Copy link
Contributor

@bgoldberg122 bgoldberg122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once those last few tests are passing (you can ignore the Validate repository check)

@j8-redis
Copy link
Collaborator Author

HI
I've reverted the CODEOWNERS commit and now it's showing up as a failure. Should I assume that I can ignore this failure as well as the lint issue? I think I have a fix for the lint issue but it's ugly and not good practice.

@j8-redis j8-redis requested a review from a team as a code owner June 20, 2024 14:00
@emarsha94 emarsha94 requested a review from bgoldberg122 June 20, 2024 15:24
@bgoldberg122
Copy link
Contributor

bgoldberg122 commented Jun 20, 2024

HI I've reverted the CODEOWNERS commit and now it's showing up as a failure. Should I assume that I can ignore this failure as well as the lint issue? I think I have a fix for the lint issue but it's ugly and not good practice.

@j8-redis Yes, you can ignore the CODEOWNERS failure. I think the lint issue needs to be fixed though -- @iliakur can you please confirm?

Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for docs

@iliakur
Copy link
Contributor

iliakur commented Jun 28, 2024

HI I've reverted the CODEOWNERS commit and now it's showing up as a failure. Should I assume that I can ignore this failure as well as the lint issue? I think I have a fix for the lint issue but it's ugly and not good practice.

@j8-redis Yes, you can ignore the CODEOWNERS failure. I think the lint issue needs to be fixed though -- @iliakur can you please confirm?

@j8-redis @bgoldberg122 the validation is in fact correct. The logs-backend team wants to co-own all logs pipelines in integrations. So you should get the validation to pass by adding them back to Codeowners please.

@bgoldberg122
Copy link
Contributor

HI I've reverted the CODEOWNERS commit and now it's showing up as a failure. Should I assume that I can ignore this failure as well as the lint issue? I think I have a fix for the lint issue but it's ugly and not good practice.

@j8-redis Yes, you can ignore the CODEOWNERS failure. I think the lint issue needs to be fixed though -- @iliakur can you please confirm?

@j8-redis @bgoldberg122 the validation is in fact correct. The logs-backend team wants to co-own all logs pipelines in integrations. So you should get the validation to pass by adding them back to Codeowners please.

@iliakur The codeowners error is not for this integration, so I will fix it in a separate PR

@bgoldberg122 bgoldberg122 merged commit 744eb8f into DataDog:master Jul 1, 2024
24 of 27 checks passed
bgoldberg122 added a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants