-
Notifications
You must be signed in to change notification settings - Fork 799
Redis enterprise - added dash to name of overview dashboard #2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis enterprise - added dash to name of overview dashboard #2417
Conversation
This reverts commit 105a35d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me once those last few tests are passing (you can ignore the Validate repository
check)
HI |
@j8-redis Yes, you can ignore the CODEOWNERS failure. I think the lint issue needs to be fixed though -- @iliakur can you please confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for docs
@j8-redis @bgoldberg122 the validation is in fact correct. The logs-backend team wants to co-own all logs pipelines in integrations. So you should get the validation to pass by adding them back to Codeowners please. |
@iliakur The codeowners error is not for this integration, so I will fix it in a separate PR |
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?