-
Notifications
You must be signed in to change notification settings - Fork 796
[ECOINT-159] Add Contrast Security ADR integration #2685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Created a DOCS card for team review. |
Just flagging for the team that I'm the docs reviewer on this PR. Thank you! |
@jhgilbert ready for review, thanks! |
contrast_security_adr/assets/dashboards/contrast_security_adr.json
Outdated
Show resolved
Hide resolved
@rtrieu ready for another review, thanks. |
Review from jhgilbert is dismissed. Related teams and files:
- documentation
- contrast_security_adr/README.md
- contrast_security_adr/assets/dashboards/contrast_security_adr.json
- contrast_security_adr/manifest.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. need to clean up logs.
dbec0d2
to
ea9e32c
Compare
ea9e32c
to
2c46077
Compare
2c46077
to
f42c27c
Compare
@@ -0,0 +1,337 @@ | |||
id: contrast-security-adr | |||
# See app_id in your integration's manifest.json file to learn more: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can remove these comments, they are here just to help create the integration
type: string | ||
pipeline: | ||
type: pipeline | ||
name: " Contrast ADR Pipeline" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove the space before Contrast
- | ||
sample: |- | ||
{ | ||
"severity" : "CRITICAL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should create a status-remapper in your pipeline to make sure the log is properly tag with this severity property, like:
- type: status-remapper
name: Define `severity` as the official status of the log
enabled: true
sources:
- severity
Integration Contrast Security ADR has been created in publishing platform