Skip to content

[ECOINT-159] Add Contrast Security ADR integration #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dd-pub-platform[bot]
Copy link
Contributor

Integration Contrast Security ADR has been created in publishing platform

@dd-pub-platform dd-pub-platform bot requested review from a team as code owners May 8, 2025 10:05
@rtrieu rtrieu added the editorial review Waiting on a more in-depth review from a docs team editor label May 8, 2025
@rtrieu
Copy link
Contributor

rtrieu commented May 8, 2025

Created a DOCS card for team review.

@dd-dominic dd-dominic changed the title Add Contrast Security ADR integration [ECOINT-159] Add Contrast Security ADR integration May 8, 2025
@jhgilbert jhgilbert self-requested a review May 9, 2025 15:55
@jhgilbert
Copy link
Contributor

Just flagging for the team that I'm the docs reviewer on this PR. Thank you!

@dd-dominic
Copy link
Collaborator

@jhgilbert ready for review, thanks!

@dd-dominic
Copy link
Collaborator

@rtrieu ready for another review, thanks.

jhgilbert
jhgilbert previously approved these changes May 22, 2025
@dd-dominic dd-dominic requested review from a team and davidfeng-datadog and removed request for a team May 23, 2025 16:32
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed jhgilbert’s stale review June 2, 2025 15:41

Review from jhgilbert is dismissed. Related teams and files:

  • documentation
    • contrast_security_adr/README.md
    • contrast_security_adr/assets/dashboards/contrast_security_adr.json
    • contrast_security_adr/manifest.json
Copy link
Collaborator

@dd-dominic dd-dominic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. need to clean up logs.

@davidfeng-datadog davidfeng-datadog force-pushed the pub_platform__contrast_security_adr branch from dbec0d2 to ea9e32c Compare June 5, 2025 20:59
@davidfeng-datadog davidfeng-datadog requested a review from a team as a code owner June 5, 2025 20:59
@davidfeng-datadog davidfeng-datadog force-pushed the pub_platform__contrast_security_adr branch from ea9e32c to 2c46077 Compare June 6, 2025 15:24
@davidfeng-datadog davidfeng-datadog force-pushed the pub_platform__contrast_security_adr branch from 2c46077 to f42c27c Compare June 9, 2025 14:59
@@ -0,0 +1,337 @@
id: contrast-security-adr
# See app_id in your integration's manifest.json file to learn more:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you can remove these comments, they are here just to help create the integration

type: string
pipeline:
type: pipeline
name: " Contrast ADR Pipeline"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove the space before Contrast

-
sample: |-
{
"severity" : "CRITICAL",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should create a status-remapper in your pipeline to make sure the log is properly tag with this severity property, like:

    - type: status-remapper
      name: Define `severity` as the official status of the log
      enabled: true
      sources:
        - severity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants