-
Notifications
You must be signed in to change notification settings - Fork 799
[ECOINT-40] Add Gravitee integration #2695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm the assigned reviewer from Documentation. |
Can you fix the linter issues for logs and ask for a review in the ticket once it’s ready? LOI-471 |
7b001b1
to
b33cbe9
Compare
gravitee/assets/logs/gravitee.yaml
Outdated
sourceType: attribute | ||
target: gravitee.apiName | ||
targetType: attribute | ||
preserveSource: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we're choosing to preserve the source here? Unless it's strictly needed for backward compatibility, we’d usually prefer to set preserveSource: false
to avoid storing the same information twice.
Review from urseberry is dismissed. Related teams and files:
- documentation
- gravitee/metadata.csv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for logs but there is a remaining unrelated validation check that needs to be addressed: https://github.com/DataDog/integrations-extras/actions/runs/16374260672/job/46270126793?pr=2695
Review from baturalp-dd is dismissed. Related teams and files:
- logs-backend
- gravitee/assets/logs/gravitee.yaml
- gravitee/assets/logs/gravitee_tests.yaml
- logs-integrations-reviewers
- gravitee/assets/logs/gravitee.yaml
- gravitee/assets/logs/gravitee_tests.yaml
Integration Gravitee has been created in publishing platform