When generating dsd metrics, always attempt to use each context once #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottopell
force-pushed
the
sopell/round-robin-contexts
branch
from
be55ea8 to
abf5560
Compare
scottopell
force-pushed
the
sopell/round-robin-contexts
branch
from
abf5560 to
b206582
Compare
Collaborator
|
@scottopell keep or close do you think? Also CC @tobz . |
Collaborator
|
I like this idea. If we have an interest in it, glad to see this PR re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the way that dogstatsd metrics generation works by attempting to always use all contexts
Motivation
It is surprising and unintuitive to configure lading and not see the expected traffic. This helps.
Related issues
Additional Notes