--do not merge-- Benchmark Branch for storage key-based Request #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This updates the bugfix guidelines to make them less strict. In particular, after this change, we would start releasing bugfix releases under the following cases: 1. Lack of consensus of SIG leads on whether to release a bugfix version within one working day after a report has been made 2. Issues that have not been reported by multiple people, but that are known to be used in production This also: - Explicitly lists difficulties with debugging and troubleshooting as 'severe enough' - Explicitly states that the release manager is responsible for bugfix releases
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description While working on open-telemetry#12981, I would have found it useful to have these tests, since they surfaced a bug when enabling `DecodeNil`.
…etry#13001) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description If we enable `DecodeNil` as true, we may have [untyped nils](https://go.dev/doc/faq#nil_error) being passed. Unfortunately, these are not valid values for `reflect`, which leads to surprising behavior such as golang/go/issues/51649. Unfortunately, the default hooks from mapstructure do not deal with this properly. To account for this, we: - Vendor and change the `ComposeDecodeHookFunc` function so that this case is accounted for the kinds of hooks that just won't work with untyped nils - Create a safe wrapper for the hooks that do work with untyped nils. This wrapper is used in all hooks, but in the interest of keeping as close to what I would imagine upstream will accept, I did not add this to the compose function. This should not have any end-user observable behavior. <!-- Issue number if applicable --> #### Link to tracking issue Attempt to work around open-telemetry#12996 (comment) --------- Co-authored-by: Evan Bradley <[email protected]>
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (79.48%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
- Coverage 91.67% 91.58% -0.10%
==========================================
Files 503 504 +1
Lines 27819 27981 +162
==========================================
+ Hits 25502 25625 +123
- Misses 1828 1859 +31
- Partials 489 497 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
run benchmark for Persistent queue with following approach:
Link to tracking issue
Relates to open-telemetry#12934
Testing
Runs benchmark with persistent queue with filebacked storage extension