Skip to content

Test build on Windows 2022 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Test build on Windows 2022 #218

wants to merge 1 commit into from

Conversation

szegedi
Copy link

@szegedi szegedi commented Jun 11, 2025

Test build on Windows 2022 for DataDog/action-prebuildify#73. Not to be merged.

@szegedi szegedi added the semver-patch Bug or security fixes, mainly label Jun 11, 2025
@@ -35,7 +35,7 @@ jobs:
- run: npm run test:js-valgrind

build:
uses: Datadog/action-prebuildify/.github/workflows/build.yml@main
uses: Datadog/action-prebuildify/.github/workflows/build.yml@szegedi/new-windows

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag instead of a hash. (...read more)

Pin GitHub Actions by commit hash to ensure supply chain security.

Using a branch (@main) or tag (@v1) allows for implicit updates, which can introduce unexpected or malicious changes. Instead, always pin actions to a full length commit SHA. You can find the commit SHA for the latest tag from the action’s repository and ensure frequent updates via auto-updaters such as dependabot. Include a comment with the corresponding full-length SemVer tag for clarity:

      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

View in Datadog  Leave us feedback  Documentation

@@ -7,7 +7,7 @@ on:

jobs:
build:
uses: Datadog/action-prebuildify/.github/workflows/build.yml@main
uses: Datadog/action-prebuildify/.github/workflows/build.yml@szegedi/new-windows

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag instead of a hash. (...read more)

Pin GitHub Actions by commit hash to ensure supply chain security.

Using a branch (@main) or tag (@v1) allows for implicit updates, which can introduce unexpected or malicious changes. Instead, always pin actions to a full length commit SHA. You can find the commit SHA for the latest tag from the action’s repository and ensure frequent updates via auto-updaters such as dependabot. Include a comment with the corresponding full-length SemVer tag for clarity:

      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

View in Datadog  Leave us feedback  Documentation

Copy link

Overall package size

Self size: 1.58 MB
Deduped: 1.95 MB
No deduping: 1.95 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.4 | 226 kB | 226 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2025

Benchmarks

Benchmark execution time: 2025-06-11 14:02:06

Comparing candidate commit b23e526 in PR branch szegedi/new-windows with baseline commit 2f6f2f8 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 90 metrics, 29 unstable metrics.

scenario:profiler-light-load-with-wall-profiler-22

  • 🟩 cpu_user_time [-12.553ms; -5.149ms] or [-11.036%; -4.527%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug or security fixes, mainly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant