Skip to content

Update min-node-version in release.yml to 18 #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

szegedi
Copy link

@szegedi szegedi commented Jun 12, 2025

What does this PR do?:
Updates min-node-version in release.yml to 18

Motivation:
Can't ship a release without fixing this as #215 uses V8 API present in 18+.

JIRA: SCP-759

@szegedi szegedi requested a review from nsavoire as a code owner June 12, 2025 07:32
Copy link

Overall package size

Self size: 1.58 MB
Deduped: 1.95 MB
No deduping: 1.95 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.4 | 226 kB | 226 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegedi szegedi added the semver-patch Bug or security fixes, mainly label Jun 12, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jun 12, 2025

Benchmarks

Benchmark execution time: 2025-06-12 07:34:41

Comparing candidate commit 9e3e911 in PR branch szegedi/bump-min-release-version with baseline commit 2f6f2f8 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 89 metrics, 29 unstable metrics.

scenario:profiler-light-load-no-wall-profiler-18

  • 🟩 cpu_user_time [-7.574ms; -1.408ms] or [-8.392%; -1.560%]

scenario:profiler-light-load-no-wall-profiler-22

  • 🟩 cpu_user_time [-6.842ms; -1.981ms] or [-9.236%; -2.674%]

@szegedi szegedi merged commit efa5480 into main Jun 12, 2025
56 of 57 checks passed
@szegedi szegedi deleted the szegedi/bump-min-release-version branch June 12, 2025 07:39
@szegedi szegedi mentioned this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug or security fixes, mainly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants