Skip to content

[ruby] [APMAPI-1116] Enable Stable Config Phase 1 #4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vpellan
Copy link
Contributor

@vpellan vpellan commented May 14, 2025

Motivation

Stable config has been merged in dd-trace-rb

Changes

Adds next dd-trace-rb release to manifest for stable config.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@vpellan vpellan changed the title [ruby] Enable Stable Config [ruby] [APMAPI-1116] Enable Stable Config May 14, 2025
@vpellan vpellan force-pushed the vpellan/ruby-enable-stable-config branch from ed1bc3b to beadcc3 Compare June 27, 2025 07:58
@vpellan vpellan marked this pull request as ready for review June 27, 2025 07:58
@vpellan vpellan requested review from a team as code owners June 27, 2025 07:58
@vpellan vpellan changed the title [ruby] [APMAPI-1116] Enable Stable Config [ruby] [APMAPI-1116] Enable Stable Config Phase 1 Jun 27, 2025
@@ -748,7 +748,7 @@ tests/:
Test_Config_TraceEnabled: v2.0.0
Test_Config_TraceLogDirectory: missing_feature
Test_Config_UnifiedServiceTagging: v2.5.0
Test_Stable_Config_Default: missing_feature
Test_Stable_Config_Default: v2.17.1-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't run the test yet, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants