Skip to content

Enable Stable Config Phase 1 tests #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Jun 18, 2025

Motivation

Hands Off Configs Phase 1 was merged into dd-trace-go

Changes

Enables the Test_Stable_Config_Default test for Go. Also, modifies the Golang parametric app logic for getting tracer config in the following ways:

  • Updates the existing logic to include data_streams_enabled information
  • Adds to the existing logic by querying the Profiler startup log to get profiling_enabled information

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mtoffl01 mtoffl01 marked this pull request as ready for review June 24, 2025 14:51
@mtoffl01 mtoffl01 requested review from a team and mabdinur as code owners June 24, 2025 14:51
@mtoffl01 mtoffl01 changed the title [Go] Enable Stable Config Phase 1 tests Enable Stable Config Phase 1 tests Jun 25, 2025
@mtoffl01 mtoffl01 requested a review from cbeauchesne June 26, 2025 18:11
@mtoffl01 mtoffl01 requested review from a team as code owners June 27, 2025 17:11
@mtoffl01 mtoffl01 requested review from emmettbutler and smola and removed request for a team June 27, 2025 17:11
@mtoffl01 mtoffl01 requested a review from jandro996 June 27, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants