-
Notifications
You must be signed in to change notification settings - Fork 14
Added tests for checking injection metadata #4823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are ci failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default on system-tests pipeline, when you create a PR is going to use the latest released artifacts. You need to force the run for the latest snapshot to activate the tests.
I did that:
Go to the dd-trace-py gitlab pipelines:
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/pipelines
Look for the latest main branch pipeline, and click on it. After clicking you will see in the url something like this:
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/pipelines/68939911
The latest snapshot identifier for the python tracer OCI image would be: pipeline-68939911
To use it on system-tests you need to run the system-tests docker ssi scenario using the env variable:
DD_INSTALLER_LIBRARY_VERSION=pipeline-68939911
Go to https://gitlab.ddbuild.io/DataDog/system-tests/-/pipelines , select “Run Pipeline” select your branch (INPLAT-652) and add the variables:
- SYSTEM_TESTS_SCENARIOS_GROUPS: DOCKER_SSI
- CI_ENVIRONMENT: dev
- DD_INSTALLER_LIBRARY_VERSION=pipeline-68939911
I launched but it’s failing for python:
https://gitlab.ddbuild.io/DataDog/system-tests/-/pipelines/68950231
Motivation
This PR was prompted by the addition of new injection metadata fields to telemetry forwarding for python.
Changes
Added new validation checks for injection metadata.
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present