[datadog_service_account] Implement exact match filtering #2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retsguj
added
aaa-access
changelog/feature
changelog/improvement
and removed
changelog/feature
labels
retsguj
changed the title
estherk15
approved these changes
Jun 18, 2024
nkzou
approved these changes
Jun 20, 2024
bharling
pushed a commit
to bharling/terraform-provider-datadog
that referenced
this pull request
Jul 8, 2024
…counts (DataDog#2434) * init * fix test * make docs * hmm * more * make docs again * try fix * try unknown? * oops * [datadog_service_account] Implement exact match filtering (DataDog#2447) * add exact match * make docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datadoghq.atlassian.net/browse/ACCESS-2606
I modeled this off of the existing exact match filtering in
data_source_datadog_userNot sure whether I should match by name or email first, or whether it really even matters.
It didn't make sense to me to exact match by role, even if the filter string will filter for roles...