[datadog_service_definition_yaml] Fix panic when contact attributes exists but are empty (nil) #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xists but are empty (nil)
ecdatadog
commented
Jan 24, 2025
| } | ||
| nameLVal, nameLOk := sortedContacts[i]["name"] | ||
| nameRVal, nameROk := sortedContacts[j]["name"] | ||
| if nameLOk && nameROk { |
There was a problem hiding this comment.
The last field has different condition as it doesn't test the (in)equality but it has no impact for the logic of the compare.
KruthiVuppala
approved these changes
Feb 3, 2025
amaskara-dd
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2801
Prevents conversion without check so there is no panic if people describe service catalog with contact having "nil" attribute.