-
Notifications
You must be signed in to change notification settings - Fork 3
Change the amount type from DOUBLE to DECIMAL #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3422476
to
ea1949e
Compare
f77c882
to
dd81eee
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dd81eee
to
c3c7cbd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c3c7cbd
to
bfa3d74
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bfa3d74
to
5eb597b
Compare
Recce SummaryManifest Information
Lineage Graphgraph LR
model.jaffle_shop.stg_payments["stg_payments
[What's Changed]
Code, Schema"]
style model.jaffle_shop.stg_payments stroke:#ffa502
model.jaffle_shop.stg_payments---->model.jaffle_shop.orders
model.jaffle_shop.stg_payments---->model.jaffle_shop.customers
model.jaffle_shop.orders["orders
[What's Changed]
Schema"]
model.jaffle_shop.customers["customers
[What's Changed]
Schema"]
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]
model.jaffle_shop.customer_segments["customer_segments"]
Checks Summary
Checks of Data Mismatch Detected
See PR page: https://cloud.datarecce.io/DataRecce/jaffle_shop_duckdb/pulls/3 How to check the recce result# Launch the recce server based on the state file
recce server --review --cloud --password yummy_jaffle
# Open the recce server http://localhost:8000 by your browser |
13b9eea
to
48d079b
Compare
cbb7071
to
876790a
Compare
876790a
to
675f3f4
Compare
675f3f4
to
2f94dcb
Compare
675f3f4
to
2783f65
Compare
2783f65
to
ddba084
Compare
ddba084
to
b2bc335
Compare
b2bc335
to
de73e11
Compare
de73e11
to
52ddef8
Compare
We found that the round effect may not be used in the jaffle shop analysis. We use to the type change instead. Here is the old one
|
6d74c85
to
301297e
Compare
Signed-off-by: popcorny <[email protected]>
301297e
to
79774e4
Compare
Overview:
This PR changes the amount type from DOUBLE to DECIMAL(10,2). Because for currency column, it make more sense to use the DECIMAL type instead of DOUBLE type.
Changes:
Rationale:
To better understand and mitigate any potential distortions caused by data rounding.
UPDATED (2025/03/07):
Please see the comment below