Translation of /testing/index.md page. #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks a lot for your contribution @antoheri ❤️ I commented a couple of tiny typos and a few proposals to improve a little bit some sentences.
guides/testing/index.md
Outdated
| @@ -1,78 +1,78 @@ | |||
| Ember gives you **the power to write tests and be productive from day one**. You can be confident that your app will be correct today and years from now. A question remains: _How_ should you write tests? | |||
| Ember vous donne **la puissance d'écrire des tests et d'être productif dès le premier jour**. Vous pouvez être sûr que votre application fonctionnera correctement aujourd'hui et dans des années. Une question demeure : Comment devriez-vous écrire des tests ? | |||
There was a problem hiding this comment.
Better phrasing:
Suggested change
| Ember vous donne **la puissance d'écrire des tests et d'être productif dès le premier jour**. Vous pouvez être sûr que votre application fonctionnera correctement aujourd'hui et dans des années. Une question demeure : Comment devriez-vous écrire des tests ? | |
| Ember vous donne **la puissance d'écrire des tests et d'être productif dès le premier jour**. Vous pouvez être sûr que votre application fonctionnera correctement aujourd'hui et dans les années à venir. Une question demeure : Comment devriez-vous écrire des tests ? |
|
Thank's for the review and the suggestions ! |
MrChocolatine
requested changes
Oct 7, 2024
MrChocolatine
approved these changes
Oct 7, 2024
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
BlueCutOfficial
force-pushed
the
master
branch
from
05c76c9 to
97d6b21
Compare
|
I added the linter and rebased the PR to resolve the conflict with catchup 5.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111