Add Logger to Output Query Logs #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genya0407
reviewed
Jul 4, 2024
| @@ -89,7 +89,7 @@ MysqlRewinder.setup(db_configs, adapter: :mysql2) | |||
| If you want to use MysqlRewinder with ActiveRecord, do the following: | |||
|
|
|||
| * Generate db_configs from `ActiveRecord::Base.configurations` | |||
| * Pass `ActiveRecord::SchemaMigration.new(nil).table_name` and `ActiveRecord::Base.internal_metadata_table_name` to `DatabaseRewinder.setup` as `except_tables` | |||
| * Pass `ActiveRecord::SchemaMigration.new(nil).table_name` and `ActiveRecord::Base.internal_metadata_table_name` to `MysqlRewinder.setup` as `except_tables` | |||
lib/mysql_rewinder/cleaner.rb
Outdated
| private | ||
|
|
||
| def log_sql(sql) | ||
| return yield unless @logger.debug? |
There was a problem hiding this comment.
With this, I understand that the logging code below is executed even if @logger is NullLogger, that isn't desirable.
Instead, we should set @logger = nil if logger is not passed.
Then we can write like:
def log_and_execute(sql)
return @client.execute(sql) unless @logger&.debug?
...
endThere was a problem hiding this comment.
Thanks. Fixed for 69070ff
meri025
force-pushed
the
feature/add_logger
branch
from
8a65aa8
to
a79da99
Compare
Co-authored-by: Yusuke Sangenya <[email protected]>
Co-authored-by: Yusuke Sangenya <[email protected]>
The type definition of the logger faced the same issue as described in ruby/rbs#1482, so it was set to untyped.
meri025
force-pushed
the
feature/add_logger
branch
from
a79da99
to
d9542d9
Compare
genya0407
reviewed
Jul 4, 2024
genya0407
reviewed
Jul 4, 2024
Co-authored-by: Yusuke Sangenya <[email protected]>
genya0407
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a logger to output query logs when the logger is specified in the setup. This enhancement will allow for better tracking and debugging of queries, especially during development and testing.
Changes
Other Information
Checklist