Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debug Logs #9

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Add Debug Logs #9

merged 3 commits into from
Jul 17, 2024

Conversation

meri025
Copy link
Contributor

@meri025 meri025 commented Jul 16, 2024

Summary

This pull request adds debug logs to enhanse the visibility of certain operations.
The added logs provide information on the following:

  • Database for Delete SQL
    Logs the target database when a DELETE SQL statement is issued.
  • Missing Target Tables for Delete
    Logs a message when there are no target tables specified.
  • File Deletion Details
    Logs file name about the recording files that are to be deleted.

Other Information

Checklist

Copy link
Contributor

@genya0407 genya0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've commented, please check.

lib/mysql_rewinder.rb Outdated Show resolved Hide resolved
lib/mysql_rewinder/cleaner.rb Outdated Show resolved Hide resolved
meri025 and others added 2 commits July 17, 2024 13:33
Co-authored-by: Yusuke Sangenya <[email protected]>
Co-authored-by: Yusuke Sangenya <[email protected]>
@genya0407 genya0407 merged commit 3772833 into DeNA:trunk Jul 17, 2024
10 checks passed
@meri025 meri025 deleted the add-log branch July 17, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants