Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Trace functionality by adding support for InterpretedFunction kernels. In addition to allowing InterpretedFunction in the Trace constructor, the decorator has been updated to wrap both JITFunction and InterpretedFunction and provide a clearer error message.
- Updated Trace.init to accept either JITFunction or InterpretedFunction.
- Modified the decorator to support both kernel types and adjusted error messaging.
Comments suppressed due to low confidence (1)
triton_viz/core/trace.py:37
- The constructor's type hint still restricts kernel to JITFunction even though the implementation now supports InterpretedFunction. Consider updating the signature to accept Union[JITFunction, InterpretedFunction] for clarity and consistency.
def __init__(self, kernel: JITFunction, client: Union[str, Client]) -> None:
Collaborator
Author
Thanks. Now fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FIX] Trace now supports
InterpretedFunction:Traceconstructor now accepts eitherJITFunctionorInterpretedFunction(re-using the latter or wrapping the former)trace()decorator wraps both types on first use, and the error message lists all accepted kernel types.